Skip to content

convert 2PC in TiDB sequence diagram from PNG to Mermaid code#21423

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
Oreoxmt:mermaid-2pc-in-tidb
Mar 12, 2026
Merged

convert 2PC in TiDB sequence diagram from PNG to Mermaid code#21423
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
Oreoxmt:mermaid-2pc-in-tidb

Conversation

@Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Mar 10, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 10, 2026
@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. labels Mar 11, 2026
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 11, 2026
@Oreoxmt Oreoxmt self-assigned this Mar 11, 2026
@Oreoxmt Oreoxmt requested a review from lilin90 March 11, 2026 02:40
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 12, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 12, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-12 10:26:02.148033008 +0000 UTC m=+518593.660090669: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt Oreoxmt added the lgtm label Mar 12, 2026
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Mar 12, 2026

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 12, 2026
@ti-chi-bot ti-chi-bot bot merged commit b386cd6 into pingcap:master Mar 12, 2026
10 checks passed
@Oreoxmt Oreoxmt deleted the mermaid-2pc-in-tidb branch March 12, 2026 11:28
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Mar 12, 2026
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants